From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: kunit: Add documentation for warning backtrace suppression API Date: Sat, 16 May 2026 09:18:01 +1000 Message-ID: In-Reply-To: <20260515-kunit_add_support-v13-4-18ee42f96e7b@redhat.com> References: <20260515-kunit_add_support-v13-0-18ee42f96e7b@redhat.com> <20260515-kunit_add_support-v13-4-18ee42f96e7b@redhat.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review The documentation is clear and shows both API forms with examples.=20 **Minor nit:** The documentation shows the direct API example checking the = warning count *after* `kunit_end_suppress_warning()`: ```rst + w =3D kunit_start_suppress_warning(test); + trigger_backtrace(); + kunit_end_suppress_warning(test, w); + + KUNIT_EXPECT_EQ(test, kunit_suppressed_warning_count(w), 1); ``` This works because the handle memory is managed by `kunit_kzalloc()` and re= mains valid until test exit =E2=80=94 the `end` call only removes the node = from the RCU list, it doesn't free the struct. This is an important propert= y that makes the direct API more ergonomic than the scoped form for post-sc= ope count checks. The code comment in patch 1 explains this, and the doc ex= ample demonstrates it. Good. **Also good:** The patch fixes a missing newline at end of file in usage.rs= t: ``` - } \ No newline at end of file + } ``` **No issues found.** --- **Summary:** This is a well-crafted v13 series with solid design, comprehen= sive tests, and clean code. The RCU + spinlock synchronization is standard = kernel practice, the static branch gives zero overhead outside tests, and t= he `in_task()` guard prevents false suppression from interrupt context. The= series has appropriate reviews from KUnit and security maintainers. No blo= cking issues found from a DRM subsystem perspective; the drm_rect_test chan= ges in patch 3 are clean and correct. --- Generated by Claude Code Patch Reviewer