From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: refactor SEC2 booter loading into BooterFirmware::run()
Date: Sat, 16 May 2026 09:54:08 +1000
Message-ID: <review-patch4-20260515-nova-unload-v5-4-c4d6250ad160@nvidia.com>
In-Reply-To: <20260515-nova-unload-v5-4-c4d6250ad160@nvidia.com>
References: <20260515-nova-unload-v5-0-c4d6250ad160@nvidia.com> <20260515-nova-unload-v5-4-c4d6250ad160@nvidia.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Clean refactoring by John Hubbard. The SEC2 reset/load/boot/check sequence moves into `BooterFirmware::run()`:

```rust
+pub(crate) fn run<T>(
+    &self,
+    dev: &device::Device<device::Bound>,
+    bar: &Bar0,
+    sec2_falcon: &Falcon<Sec2>,
+    wpr_meta: &Coherent<T>,
+) -> Result {
```

The generic `<T>` for `wpr_meta` is appropriate since `run()` only needs the DMA handle from the `Coherent`, not the inner type.

The thin `run_booter()` wrapper in boot.rs creates the firmware and immediately calls `run()`, keeping the boot flow readable. No issues.

---

---
Generated by Claude Code Patch Reviewer