From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/syncobj: add drm_syncobj_register_eventfd Date: Mon, 18 May 2026 16:53:30 +1000 Message-ID: In-Reply-To: <20260516-jorth-syncobj-v1-4-88ede9d98a81@gmail.com> References: <20260516-jorth-syncobj-v1-0-88ede9d98a81@gmail.com> <20260516-jorth-syncobj-v1-4-88ede9d98a81@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean extraction from `drm_syncobj_eventfd_ioctl()`. The `drm_syncobj_put()` call is correctly moved back to the ioctl handler. Note that the flags validation (`flags & ~DRM_SYNCOBJ_WAIT_FLAGS_WAIT_AVAILABLE`) is **not** included in the new exported function and stays only in the ioctl handler. This is inconsistent with patch 2 where the flags check was left in the caller. It does mean the exported `drm_syncobj_register_eventfd()` silently ignores unknown flags -- callers must validate themselves. --- Generated by Claude Code Patch Reviewer