From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: bridge: dw_hdmi: Use passed mode instead of stored previous_mode Date: Mon, 18 May 2026 16:41:45 +1000 Message-ID: In-Reply-To: <20260516183838.2024991-5-jonas@kwiboo.se> References: <20260516183838.2024991-1-jonas@kwiboo.se> <20260516183838.2024991-5-jonas@kwiboo.se> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status:** Correct. Fixes the `phy.ops->init` call to use the passed `mode` parameter instead of `&hdmi->previous_mode`: ```c - ret = hdmi->phy.ops->init(hdmi, hdmi->phy.data, - &connector->display_info, - &hdmi->previous_mode); + ret = hdmi->phy.ops->init(hdmi, hdmi->phy.data, display, mode); ``` Also fixes the typo "Initializateion" -> "Initialization". Extracting a `display` variable is a nice cleanup. --- Generated by Claude Code Patch Reviewer