From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/radeon: fix eDP resume from suspend on iMac11, 1 / DCE3.1 systems
Date: Thu, 04 Jun 2026 13:37:52 +1000
Message-ID: <review-patch4-20260516185226.3005-1-gilles.risch@gmail.com>
In-Reply-To: <20260516185226.3005-1-gilles.risch@gmail.com>
References: <20260518211409.4868-3-gilles.risch@gmail.com> <20260516185226.3005-1-gilles.risch@gmail.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

Superseded by v4/v5. The v3 2/2 patch narrowed the resume fix to `dmi_match=
("iMac11,1")`, which was the right direction. However:

In `atombios_set_edp_panel_power()` (v3 2/2):
```c
	if (!ASIC_IS_DCE4(rdev))
	    if (!dmi_match(DMI_PRODUCT_NAME, "iMac11,1"))
		    goto done;
```
This has an **indentation/style issue** =E2=80=94 the nested if without bra=
ces is confusing and uses spaces instead of tabs. It should be:
```c
	if (!ASIC_IS_DCE4(rdev) && !dmi_match(DMI_PRODUCT_NAME, "iMac11,1"))
		goto done;
```

---
Generated by Claude Code Patch Reviewer