From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: mfd: lm3533: set DMA mask Date: Mon, 18 May 2026 16:19:46 +1000 Message-ID: In-Reply-To: <20260517074306.30937-5-clamor95@gmail.com> References: <20260517074306.30937-1-clamor95@gmail.com> <20260517074306.30937-5-clamor95@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Questionable approach**: Setting `coherent_dma_mask =3D 0` and pointing `= dma_mask` to it is unusual and technically declares that the device can DMA= only to address 0. For a device that does not use DMA at all, the conventi= onal fix is either to not set a DMA mask (letting the framework handle it) = or to ensure the MFD child devices aren't triggering DMA configuration. The commit message mentions the warning "might be elevated to an error in t= he future" =E2=80=94 but that hasn't happened and this workaround may itsel= f become a problem. A better approach would be to investigate why the MFD c= hild platform devices trigger `of_dma_configure` and whether the MFD core s= hould suppress this. Consider checking if a recent kernel still triggers th= is warning, or discuss the approach with MFD maintainers. --- Generated by Claude Code Patch Reviewer