From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/display: scdc_helper: Add HDMI 2.0 scrambling management helpers Date: Mon, 25 May 2026 21:15:03 +1000 Message-ID: In-Reply-To: <20260520-dw-hdmi-qp-scramb-v6-4-24b74603b782@collabora.com> References: <20260520-dw-hdmi-qp-scramb-v6-0-24b74603b782@collabora.com> <20260520-dw-hdmi-qp-scramb-v6-4-24b74603b782@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review This is the core patch. Several observations: 1. **`drm_scdc_monitor_scrambler()` re-schedules unconditionally**: In `drm= _scdc_setup_scrambler()`, the delayed work is always scheduled when called.= If the monitor callback finds that scrambling status was lost and calls `d= rm_scdc_setup_scrambler()` again, it re-schedules itself, which is correct = periodic monitoring behavior. 2. **`drm_scdc_reset_crtc()` accesses `connector->state` without holding lo= cks**: The function reads `connector->state->crtc` and `crtc->state->active= ` outside of any modeset lock. While this is in a detect context where the = connection_mutex may be held, the connector state access is still technical= ly racy. However, this mirrors what `drm_bridge_helper_reset_crtc()` does i= n the existing codebase, so it follows established (if imperfect) patterns. 3. **`// TODO: Also handle HDMI 2.1 FRL link training`**: C++ style comment= . Kernel style prefers `/* */`. Minor, but will likely get flagged by check= patch. 4. **Error handling in `drm_scdc_start_scrambling()`**: The rollback on fai= lure is thorough =E2=80=94 cancels the work, clears the callback, and reset= s both scrambling and clock ratio on the sink. Good. 5. **`drm_scdc_sync_status()` early returns**: The function returns 0 when = `hdmi->funcs` is NULL, and also returns 0 when scrambler callbacks are not = set. This means non-HDMI-2.0 bridges silently succeed, which is the right b= ehavior. --- Generated by Claude Code Patch Reviewer