From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/adreno: Trust the SSoT UBWC config Date: Mon, 25 May 2026 21:41:57 +1000 Message-ID: In-Reply-To: <20260520-ubwc-rework-v5-4-72f2749bc807@oss.qualcomm.com> References: <20260520-ubwc-rework-v5-0-72f2749bc807@oss.qualcomm.com> <20260520-ubwc-rework-v5-4-72f2749bc807@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Large cleanup -- removes the `a6xx_calc_ubwc_config()` function that contained hardcoded per-GPU UBWC parameters (for a618, a619, a630, a640, a650, etc.) and the `_ubwc_config` copy in `adreno_gpu`. The a5xx and a6xx drivers now take a `const *` pointer directly from the UBWC database. This is the biggest single-patch win in the series. The deleted function was a maintenance burden -- every new a6xx GPU required manually adding its UBWC config values. Now the centralized database handles it. No issues. --- Generated by Claude Code Patch Reviewer