From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/exec, drm/xe, drm/amdgpu: Add an accessor for struct drm_exec::ticket Date: Mon, 25 May 2026 21:59:35 +1000 Message-ID: In-Reply-To: <20260520101616.41284-5-thomas.hellstrom@linux.intel.com> References: <20260520101616.41284-1-thomas.hellstrom@linux.intel.com> <20260520101616.41284-5-thomas.hellstrom@linux.intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Assessment: Good.** The accessor is trivially correct: ```c static inline struct ww_acquire_ctx *drm_exec_ticket(struct drm_exec *exec) { return &exec->ticket; } ``` All driver-side conversions are mechanical and correct. The internal uses in `drm_exec.c` (`drm_exec_cleanup`, `drm_exec_fini`, `drm_exec_lock_contended`) are deliberately not converted, which is appropriate since those are the implementation of drm_exec itself and would not need to change when subclassing. One observation about the amdgpu `dma_resv_locking_ctx` comparison: ```c - if (dma_resv_locking_ctx((*bo)->tbo.base.resv) != &parser->exec.ticket) + if (dma_resv_locking_ctx((*bo)->tbo.base.resv) != drm_exec_ticket(&parser->exec)) ``` This pointer comparison remains correct since `drm_exec_ticket` returns `&exec->ticket`, which is the same address. Minor style note: the kdoc says `drm_exec_ticket` without the `()` convention used elsewhere for function names, but this is consistent with many kernel kdoc examples and not an issue. --- Generated by Claude Code Patch Reviewer