From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/xe: Handle PUNIT errors by requesting cold-reset recovery
Date: Mon, 25 May 2026 21:57:09 +1000
Message-ID: <review-patch4-20260520113351.171119-11-mallesh.koujalagi@intel.com>
In-Reply-To: <20260520113351.171119-11-mallesh.koujalagi@intel.com>
References: <20260520113351.171119-7-mallesh.koujalagi@intel.com> <20260520113351.171119-11-mallesh.koujalagi@intel.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

The core change is correct:

```c
static void punit_error_handler(struct xe_device *xe)
{
	xe_device_set_wedged_method(xe, DRM_WEDGE_RECOVERY_COLD_RESET);
	xe_device_declare_wedged(xe);
}
```

This properly uses the wedge API (unlike the bypass in patch 1's PCI error handling path). The TODO comment it replaces is cleanly removed.

**Unnecessary includes:**

```c
+#include "xe_assert.h"
+#include "xe_device_types.h"
```

Neither `xe_assert.h` nor `xe_device_types.h` appear to be needed by the changes in this patch. `xe_device.h` (already included) transitively provides `xe_device_types.h`, and nothing in this diff uses `xe_assert`. These may have been added speculatively for patch 5, but each patch should only add headers it actually needs. If patch 5 needs them, add them there.

---

---
Generated by Claude Code Patch Reviewer