From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: inno-hdmi: Use the common TMDS char rate constant Date: Mon, 25 May 2026 21:45:01 +1000 Message-ID: In-Reply-To: <20260520144424.1633354-5-javierm@redhat.com> References: <20260520144424.1633354-1-javierm@redhat.com> <20260520144424.1633354-5-javierm@redhat.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Replaces `INNO_HDMI_MIN_TMDS_CLOCK` (25000000U) with `HDMI_TMDS_CHAR_RATE_MIN_HZ`. ```c - if (mpixelclk < INNO_HDMI_MIN_TMDS_CLOCK) + if (mpixelclk < HDMI_TMDS_CHAR_RATE_MIN_HZ) ``` Minor note: the variable is named `mpixelclk` and the original define said "TMDS_CLOCK". Since these are the same value in 8bpc RGB without pixel repetition, this is fine. The `U` suffix on the original define (`25000000U`) should be preserved in the new constant definition in patch 1/8 to avoid any signed comparison changes. No issues. **Reviewed-by tag:** Heiko Stuebner. --- Generated by Claude Code Patch Reviewer