From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: fbdev: Do not export fbcon from fbdev Date: Mon, 25 May 2026 21:30:32 +1000 Message-ID: In-Reply-To: <20260520160744.130841-5-tzimmermann@suse.de> References: <20260520160744.130841-1-tzimmermann@suse.de> <20260520160744.130841-5-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness**: This is a straightforward move of declarations from `inclu= de/linux/fbcon.h` to `drivers/video/fbdev/core/fbcon.h`. The content is ide= ntical =E2=80=94 I confirmed the `#ifdef CONFIG_FRAMEBUFFER_CONSOLE` block = and all stub definitions match exactly. **Internal header**: The declarations are appended to the existing internal= `fbcon.h` which already has fbcon-internal definitions (structs, macros fo= r the console driver). Adding the public API declarations here is a reasona= ble choice. **New includes**: The patch correctly adds `#include ` and forward declarations for `struct fb_blit_caps`, `struct fb_info`, `= struct fb_var_screeninfo`, and `struct fb_videomode` =E2=80=94 needed since= this header no longer transitively gets them from the public header chain. **MAINTAINERS**: Removing `include/linux/fbcon.h` from the FRAMEBUFFER CONS= OLE DRIVER section is correct since the file is deleted. **No concerns** with this patch. --- Generated by Claude Code Patch Reviewer