From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: rust: drm: set fops.owner from driver module pointer
Date: Mon, 25 May 2026 20:45:43 +1000 [thread overview]
Message-ID: <review-patch4-20260521-fix-fops-owner-v2-4-fd99079c5a04@linux.dev> (raw)
In-Reply-To: <20260521-fix-fops-owner-v2-4-fd99079c5a04@linux.dev>
Patch Review
This is one of the two actual bug-fix patches. Changes `create_fops()` to take an `owner: *mut bindings::module` parameter:
```rust
pub(super) const fn create_fops(owner: *mut bindings::module) -> bindings::file_operations {
```
And the call site in `device.rs`:
```rust
const GEM_FOPS: bindings::file_operations =
drm::gem::create_fops(<T::ThisModule as crate::ModuleMetadata>::THIS_MODULE.as_ptr());
```
**Observations:**
1. This directly fixes the bug described in the cover letter. With `fops.owner` set correctly, the kernel will `try_module_get()` on open and `module_put()` on close, preventing `rmmod` while file descriptors are open.
2. The path `<T::ThisModule as crate::ModuleMetadata>::THIS_MODULE.as_ptr()` correctly goes through the `Driver` trait's `ThisModule` associated type (auto-injected by `#[vtable]`) to get the module pointer. Since `T: drm::Driver` and `Driver` has `#[vtable]`, `T::ThisModule` is available and constrained to implement `ModuleMetadata`.
3. `create_fops()` is `pub(super)` and `const fn` — taking a raw pointer as parameter is fine in const context.
**No issues found.** This is the critical fix for DRM.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 10:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 7:52 [PATCH v2 0/7] Fix missing fops.owner in Rust DRM/misc abstractions Alvin Sun
2026-05-21 7:52 ` [PATCH v2 1/7] rust: module: add `THIS_MODULE` const to `ModuleMetadata` trait Alvin Sun
2026-05-25 10:45 ` Claude review: " Claude Code Review Bot
2026-05-21 7:52 ` [PATCH v2 2/7] rust: macros: auto-insert ThisModule in #[vtable] Alvin Sun
2026-05-25 10:45 ` Claude review: " Claude Code Review Bot
2026-05-21 7:52 ` [PATCH v2 3/7] rust: doctest: add LocalModule fallback for #[vtable] ThisModule Alvin Sun
2026-05-25 10:45 ` Claude review: " Claude Code Review Bot
2026-05-21 7:52 ` [PATCH v2 4/7] rust: drm: set fops.owner from driver module pointer Alvin Sun
2026-05-25 10:45 ` Claude Code Review Bot [this message]
2026-05-21 7:52 ` [PATCH v2 5/7] rust: miscdevice: " Alvin Sun
2026-05-25 10:45 ` Claude review: " Claude Code Review Bot
2026-05-21 7:52 ` [PATCH v2 6/7] rust: configfs: use `LocalModule` for `THIS_MODULE` Alvin Sun
2026-05-25 10:45 ` Claude review: " Claude Code Review Bot
2026-05-21 7:52 ` [PATCH v2 7/7] block: rnull: " Alvin Sun
2026-05-25 10:45 ` Claude review: " Claude Code Review Bot
2026-05-25 10:45 ` Claude review: Fix missing fops.owner in Rust DRM/misc abstractions Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch4-20260521-fix-fops-owner-v2-4-fd99079c5a04@linux.dev \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox