From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: pmdomain: imx: fix OF node refcount Date: Mon, 25 May 2026 20:33:07 +1000 Message-ID: In-Reply-To: <20260521-pdev-fwnode-ref-v1-4-88c324a1b8d2@oss.qualcomm.com> References: <20260521-pdev-fwnode-ref-v1-0-88c324a1b8d2@oss.qualcomm.com> <20260521-pdev-fwnode-ref-v1-4-88c324a1b8d2@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Correct fix. The commit message notes this is from `for_each_child_of_node_= scoped()` which auto-puts on scope exit, making this a double-put without t= he fix. ```c - pd_pdev->dev.of_node =3D np; + pd_pdev->dev.of_node =3D of_node_get(np); pd_pdev->dev.fwnode =3D of_fwnode_handle(np); ``` **Minor nit**: Typo in commit message =E2=80=94 "the nod after each iterati= on" should be "the node after each iteration". Note that `fwnode` is still set without refcounting here, but that's fine s= ince `platform_device_release()` only calls `of_node_put()` at this point i= n the series. Patch 14 later converts this to the helper. --- Generated by Claude Code Patch Reviewer