From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display: Add Synaptics R63455 panel support Date: Mon, 25 May 2026 20:00:02 +1000 Message-ID: In-Reply-To: <20260521-sm8650-7-1-bonded-dsi-v4-4-a4dd5e0850f1@linaro.org> References: <20260521-sm8650-7-1-bonded-dsi-v4-0-a4dd5e0850f1@linaro.org> <20260521-sm8650-7-1-bonded-dsi-v4-4-a4dd5e0850f1@linaro.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Concept**: DT binding for a dual-panel VR display driven by Synaptics R63455 controllers. **Issues:** 1. **YAML schema error in `ports`**: The line: ```yaml ports: $ref: /schemas/graph.yaml#/properties/ports ``` This is incorrect YAML syntax. It should be: ```yaml ports: $ref: /schemas/graph.yaml#/properties/ports ``` 2. **Non-standard supply naming**: Using `left-pos-supply`, `right-neg-supply`, etc. is unusual. DT bindings typically use generic supply names or names derived from the chip's pin names (e.g., `vpos-left-supply`). The `left-`/`right-` prefix convention isn't established in existing bindings. DT maintainers may push back on this. 3. **Missing port definitions**: The `ports` property references the graph schema but doesn't define `port@0` and `port@1` with their own descriptions within the schema, so the binding doesn't actually constrain or document which ports exist. 4. **Example has syntax issues**: The example DT uses `&mdss_dsi0 { ... }` overlay syntax with missing closing braces. The `};` for the `panel@0` node appears to close at the wrong level (the `};` on line 972 closes the ports node, but the panel node itself is not properly closed before `&mdss_dsi0_out`). This would fail `dt_binding_check`. 5. **`data-lanes` in example**: The example shows `data-lanes = <0 1 2>;` (3 lanes), which matches the panel driver, but this property isn't defined in the binding schema itself. --- Generated by Claude Code Patch Reviewer