From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: rust: driver core: drop drvdata before devres release
Date: Mon, 25 May 2026 19:29:13 +1000 [thread overview]
Message-ID: <review-patch4-20260521233501.1191842-5-dakr@kernel.org> (raw)
In-Reply-To: <20260521233501.1191842-5-dakr@kernel.org>
Patch Review
**This is the most critical patch in the series.** It reorders `device_unbind_cleanup()` in C code:
```c
// Before:
devres_release_all(dev);
if (dev->driver->p_cb.post_unbind_rust)
dev->driver->p_cb.post_unbind_rust(dev);
// After:
if (dev->driver->p_cb.post_unbind_rust)
dev->driver->p_cb.post_unbind_rust(dev);
devres_release_all(dev);
```
The commit message argues this is safe because "with drvdata() removed, the driver's bus device private data is only accessible by the owning driver itself." However, this changes behavior for **all** existing Rust drivers, not just HRT ones. If any existing Rust driver's Drop implementation (invoked by `post_unbind_rust`) currently relies on devres resources already being released (e.g., to avoid double-free), this reorder could break it.
That said, the opposite direction (drvdata depending on devres being alive) is the more natural dependency direction, so this reorder should be safe in practice. The comment update in `driver.rs` is also correct: devres resources are now "still valid" when drvdata is dropped.
**Question for the author:** Is there any existing Rust driver or use-case where the Drop of drvdata would conflict with devres resources still being alive? The `try_access()` path in Devres could now succeed in Drop where it previously would not — is that a concern for any current user?
---
### PATCHES 5-9/27: implement Sync for Device\<Bound\>
Five small patches adding `unsafe impl Sync for Device<Bound>` across PCI, platform, auxiliary, USB, and the base device type. Required so that `&'bound Device<Bound>` can be stored in driver data (which must be `Send + Sync`).
The safety argument is consistent across all: the underlying C struct is the same as `Device<Normal>` (which already has `Sync`), and `Bound` is a zero-sized type-state marker.
No issues.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 9:29 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 23:34 [PATCH v4 00/27] rust: device: Higher-Ranked Lifetime Types for device drivers Danilo Krummrich
2026-05-21 23:34 ` [PATCH v4 01/27] rust: alloc: remove `'static` bound on `ForeignOwnable` Danilo Krummrich
2026-05-25 9:29 ` Claude review: " Claude Code Review Bot
2026-05-21 23:34 ` [PATCH v4 02/27] rust: driver: move 'static bounds to constructor Danilo Krummrich
2026-05-25 9:29 ` Claude review: " Claude Code Review Bot
2026-05-21 23:34 ` [PATCH v4 03/27] rust: driver: decouple driver private data from driver type Danilo Krummrich
2026-05-25 9:29 ` Claude review: " Claude Code Review Bot
2026-05-21 23:34 ` [PATCH v4 04/27] rust: driver core: drop drvdata before devres release Danilo Krummrich
2026-05-25 9:29 ` Claude Code Review Bot [this message]
2026-05-21 23:34 ` [PATCH v4 05/27] rust: pci: implement Sync for Device<Bound> Danilo Krummrich
2026-05-21 23:34 ` [PATCH v4 06/27] rust: platform: " Danilo Krummrich
2026-05-21 23:34 ` [PATCH v4 07/27] rust: auxiliary: " Danilo Krummrich
2026-05-21 23:34 ` [PATCH v4 08/27] rust: usb: " Danilo Krummrich
2026-05-21 23:34 ` [PATCH v4 09/27] rust: device: " Danilo Krummrich
2026-05-21 23:34 ` [PATCH v4 10/27] rust: device: make Core and CoreInternal lifetime-parameterized Danilo Krummrich
2026-05-25 4:21 ` Eliot Courtney
2026-05-25 9:29 ` Claude review: " Claude Code Review Bot
2026-05-21 23:34 ` [PATCH v4 11/27] rust: pci: make Driver trait lifetime-parameterized Danilo Krummrich
2026-05-21 23:34 ` [PATCH v4 12/27] rust: platform: " Danilo Krummrich
2026-05-21 23:34 ` [PATCH v4 13/27] rust: auxiliary: " Danilo Krummrich
2026-05-21 23:34 ` [PATCH v4 14/27] rust: usb: " Danilo Krummrich
2026-05-25 4:31 ` Eliot Courtney
2026-05-21 23:34 ` [PATCH v4 15/27] rust: i2c: " Danilo Krummrich
2026-05-21 23:34 ` [PATCH v4 16/27] rust: driver: update module documentation for GAT-based Data type Danilo Krummrich
2026-05-25 9:29 ` Claude review: " Claude Code Review Bot
2026-05-21 23:34 ` [PATCH v4 17/27] rust: pci: make Bar lifetime-parameterized Danilo Krummrich
2026-05-25 4:37 ` Eliot Courtney
2026-05-25 9:29 ` Claude review: " Claude Code Review Bot
2026-05-21 23:34 ` [PATCH v4 18/27] rust: io: make IoMem and ExclusiveIoMem lifetime-parameterized Danilo Krummrich
2026-05-25 9:29 ` Claude review: " Claude Code Review Bot
2026-05-21 23:34 ` [PATCH v4 19/27] samples: rust: rust_driver_pci: use HRT lifetime for Bar Danilo Krummrich
2026-05-25 9:29 ` Claude review: " Claude Code Review Bot
2026-05-21 23:34 ` [PATCH v4 20/27] gpu: nova-core: separate driver type from driver data Danilo Krummrich
2026-05-25 4:40 ` Eliot Courtney
2026-05-25 9:29 ` Claude review: " Claude Code Review Bot
2026-05-21 23:34 ` [PATCH v4 21/27] rust: types: add `ForLt` trait for higher-ranked lifetime support Danilo Krummrich
2026-05-23 15:46 ` Danilo Krummrich
2026-05-25 9:29 ` Claude review: " Claude Code Review Bot
2026-05-21 23:34 ` [PATCH v4 22/27] rust: auxiliary: generalize Registration over ForLt Danilo Krummrich
2026-05-25 6:03 ` Eliot Courtney
2026-05-25 9:29 ` Claude review: " Claude Code Review Bot
2026-05-21 23:34 ` [PATCH v4 23/27] samples: rust: rust_driver_auxiliary: showcase lifetime-bound registration data Danilo Krummrich
2026-05-25 9:29 ` Claude review: " Claude Code Review Bot
2026-05-21 23:34 ` [PATCH REF v4 24/27] gpu: nova-core: use lifetime for Bar Danilo Krummrich
2026-05-21 23:34 ` [PATCH REF v4 25/27] gpu: nova-core: unregister sysmem flush page from Drop Danilo Krummrich
2026-05-21 23:34 ` [PATCH REF v4 26/27] gpu: nova-core: replace ARef<Device> with &'bound Device in SysmemFlush Danilo Krummrich
2026-05-21 23:34 ` [PATCH REF v4 27/27] gpu: drm: tyr: use lifetime for IoMem Danilo Krummrich
2026-05-22 10:14 ` [PATCH v4 00/27] rust: device: Higher-Ranked Lifetime Types for device drivers Greg KH
2026-05-25 9:29 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-25 20:20 [PATCH v5 00/24] " Danilo Krummrich
2026-05-25 20:20 ` [PATCH v5 05/24] rust: driver core: drop drvdata before devres release Danilo Krummrich
2026-05-25 20:47 ` Claude review: " Claude Code Review Bot
2026-05-17 0:00 [PATCH v3 00/27] rust: device: Higher-Ranked Lifetime Types for device drivers Danilo Krummrich
2026-05-17 0:00 ` [PATCH v3 04/27] rust: driver core: drop drvdata before devres release Danilo Krummrich
2026-05-18 6:24 ` Claude review: " Claude Code Review Bot
2026-05-06 21:50 [PATCH v2 00/25] rust: device: Higher-Ranked Lifetime Types for device drivers Danilo Krummrich
2026-05-06 21:50 ` [PATCH v2 01/25] rust: driver core: drop drvdata before devres release Danilo Krummrich
2026-05-07 3:02 ` Claude review: " Claude Code Review Bot
2026-04-27 22:10 [PATCH 00/24] rust: device: Higher-Ranked Lifetime Types for device drivers Danilo Krummrich
2026-04-27 22:10 ` [PATCH 01/24] rust: driver core: drop drvdata before devres release Danilo Krummrich
2026-04-28 3:47 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch4-20260521233501.1191842-5-dakr@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox