From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: qcom: qcs6490-radxa-dragon-q6a: Add regulator supplies and disable EUD Date: Mon, 25 May 2026 19:16:37 +1000 Message-ID: In-Reply-To: <20260522060645.4399-5-graham.oconnor@gmail.com> References: <20260522060645.4399-1-graham.oconnor@gmail.com> <20260522060645.4399-5-graham.oconnor@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review ```dts +&qfprom { + vcc-supply = <&vreg_l1c_1p8>; +}; + +&pcie0 { + vdda-supply = <&vreg_l1c_1p8>; + vddpe-3v3-supply = <&vreg_bob_3p296>; +}; + +&pcie1 { + vdda-supply = <&vreg_l1c_1p8>; + vddpe-3v3-supply = <&vreg_bob_3p296>; +}; + +&eud { + status = "disabled"; +}; ``` **No significant issues.** This is straightforward DTS plumbing. The `vreg_bob_3p296` for `vddpe-3v3` is within tolerance for a nominal 3.3V rail (BOB regulators commonly produce slightly non-standard voltages). Disabling EUD for normal USB operation is standard practice. Minor: the commit message bundles two conceptually separate changes (regulator supplies + EUD disable). These could be separate patches for cleaner bisection, but it's not a hard requirement. --- --- Generated by Claude Code Patch Reviewer