From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: fbdev: Do not export fbcon from fbdev Date: Mon, 25 May 2026 18:52:08 +1000 Message-ID: In-Reply-To: <20260522123019.211059-5-tzimmermann@suse.de> References: <20260522123019.211059-1-tzimmermann@suse.de> <20260522123019.211059-5-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Moves all declarations from `include/linux/fbcon.h` into the existing inter= nal `drivers/video/fbdev/core/fbcon.h`, adds necessary forward declarations= and `#include `, then deletes the public header. The approach of appending to the existing internal `fbcon.h` (which already= has internal struct definitions and macros) is correct. The forward declar= ations for `struct fb_blit_caps`, `struct fb_info`, `struct fb_var_screenin= fo`, and `struct fb_videomode` are needed since the internal header didn't = previously include ``. `fbcon.c` already includes the local `"fbcon.h"` (line 85 in current tree),= so dropping `` (line 73) is safe =E2=80=94 the declarations= remain visible. `fb_chrdev.c` and `fbmem.c` correctly switch from `` to `"fb= con.h"`. The `MAINTAINERS` update removing the deleted file is correct. **No issues.** --- Generated by Claude Code Patch Reviewer