From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/xe/hw_error: Use HW_ERR prefix in log Date: Mon, 25 May 2026 17:57:41 +1000 Message-ID: In-Reply-To: <20260523050212.557292-5-raag.jadav@intel.com> References: <20260523050212.557292-1-raag.jadav@intel.com> <20260523050212.557292-5-raag.jadav@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Verdict: Correct change, questionable Fixes tag.** The change itself is straightforward and correct =E2=80=94 `HW_ERR` is defi= ned in `include/linux/printk.h` as `"[Hardware Error]: "` and is the standa= rd kernel convention for hardware error reporting. The string concatenation= with the format literal is fine: ```c drm_warn(&xe->drm, HW_ERR "%s %s detected\n", name, severity_str); ``` **On the Fixes tag:** The referenced commit `01aab7e1c9d4` ("drm/xe/xe_hw_e= rror: Add support for PVC SoC errors") simply didn't use the `HW_ERR` prefi= x. Missing a log prefix isn't a functional bug =E2=80=94 this is a conventi= on/consistency improvement. It might be more appropriate without a `Fixes:`= tag, or at least should not be backported to stable trees. **Pre-existing issue (not introduced by this patch):** The `log_soc_error` = messages are missing a trailing `\n`: ```c drm_warn(&xe->drm, HW_ERR "%s SOC %s detected", name, severity_str); ``` Compare with `log_hw_error` and `log_gt_err`, which both have `\n`. This in= consistency predates this patch but could be worth fixing in a follow-up. --- Generated by Claude Code Patch Reviewer