From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: rust: driver: decouple driver private data from driver type
Date: Tue, 26 May 2026 06:47:02 +1000
Message-ID: <review-patch4-20260525202921.124698-5-dakr@kernel.org>
In-Reply-To: <20260525202921.124698-5-dakr@kernel.org>
References: <20260525202921.124698-1-dakr@kernel.org> <20260525202921.124698-5-dakr@kernel.org>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Introduces `type Data: Send` on all bus driver traits, decoupling the driver struct from its private data. Changes `DriverData` to a GAT `type DriverData<'bound>`:

```rust
-    type DriverData;
+    type DriverData<'bound>;
```

All existing drivers add `type Data = Self`. The probe/unbind signatures change from `Self` to `Self::Data`:

```rust
-    fn probe(...) -> impl PinInit<Self, Error>;
+    fn probe(...) -> impl PinInit<Self::Data, Error>;
-    fn unbind(dev: ..., this: Pin<&Self>) {
+    fn unbind(dev: ..., this: Pin<&Self::Data>) {
```

Extensive but mechanical. All SAFETY comments updated from `T` to `T::Data`. The `DriverData` GAT with `'bound` is forward-looking -- it doesn't use the lifetime yet but will in patches 12-16. Clean.

---
Generated by Claude Code Patch Reviewer