From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: fbdev: Do not export fbcon from fbdev Date: Thu, 28 May 2026 12:12:51 +1000 Message-ID: In-Reply-To: <20260527151551.258659-5-tzimmermann@suse.de> References: <20260527151551.258659-1-tzimmermann@suse.de> <20260527151551.258659-5-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Clean. The declarations are moved from the public `include/linux/fbcon.h` t= o the existing private `drivers/video/fbdev/core/fbcon.h`. Since `fbcon.c` = already includes the local `"fbcon.h"` (line 84), and `fb_chrdev.c`/`fbmem.= c` now include `"fbcon.h"` instead of ``, all consumers are = covered. The forward declarations (`struct fb_blit_caps`, `struct fb_info`, etc.) an= d `#include ` are correctly added to the private he= ader to replace what came from the public header. MAINTAINERS update removing `include/linux/fbcon.h` is correct. The `EXPORT_SYMBOL` removals for `fbcon_update_vcs` and `fbcon_modechange_p= ossible` happened in patch 1 since their callers moved into fbdev core at t= hat point =E2=80=94 correctly sequenced. --- **Summary**: The series should be fine with the sh_mobile_lcdcfb fix in pat= ch 1 (`var.activate` needs `FB_ACTIVATE_ALL` set to preserve the original "= update all VCs" behavior). --- Generated by Claude Code Patch Reviewer