From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/draw: Remove unused helper drm_draw_get_char_bitmap() Date: Thu, 04 Jun 2026 16:27:42 +1000 Message-ID: In-Reply-To: <20260529140759.529929-5-tzimmermann@suse.de> References: <20260529140759.529929-1-tzimmermann@suse.de> <20260529140759.529929-5-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Removes the now-dead inline: ```c -#include ... -static inline const u8 *drm_draw_get_char_bitmap(const struct font_desc *font, - char c, size_t font_pitch) -{ - return font->data + (c * font->height) * font_pitch; -} ``` Also removes the `#include ` that was only needed for this helper. The remaining code in the header (`drm_draw_is_pixel_fg`) only uses `u8` from `` which is still included. I confirmed these were the only two callers of `drm_draw_get_char_bitmap` in the tree, so the removal is safe. **No bugs. Looks good.** --- Generated by Claude Code Patch Reviewer