From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: drm: nova: build after nova-core metadata Date: Thu, 04 Jun 2026 16:23:30 +1000 Message-ID: In-Reply-To: <20260530-nova-exports-v3-4-1202aa339ef7@nvidia.com> References: <20260530-nova-exports-v3-0-1202aa339ef7@nvidia.com> <20260530-nova-exports-v3-4-1202aa339ef7@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Looks good** Wires up nova-drm to consume nova-core's metadata: ```makefile nova_core_rmeta :=3D drivers/gpu/nova-core/libnova_core.rmeta rustflags-y +=3D --extern nova_core=3D$(objtree)/$(nova_core_rmeta) $(obj)/nova.o: | $(objtree)/$(nova_core_rmeta) ``` The order-only dependency (`|`) is correct =E2=80=94 nova-drm needs the rme= ta to exist before compilation but doesn't need to rebuild when the rmeta c= ontent changes (since symbol resolution happens at module load time via the= exports from patch 2). The recursive `$(MAKE) $(build)=3D...` to build the rmeta target in another= directory is ugly (as the comment acknowledges) but functional. This is th= e standard kernel pattern for cross-directory build dependencies. No issues. --- Generated by Claude Code Patch Reviewer