From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/v3d: Drop the queue argument from v3d_job_add_syncobjs() Date: Thu, 04 Jun 2026 14:44:43 +1000 Message-ID: In-Reply-To: <20260531-v3d-perfmon-lifetime-v2-4-60ed4485a203@igalia.com> References: <20260531-v3d-perfmon-lifetime-v2-0-60ed4485a203@igalia.com> <20260531-v3d-perfmon-lifetime-v2-4-60ed4485a203@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status**: Clean mechanical cleanup, no issues. Now that `job->queue` exists (introduced in patch 3), the explicit `enum v3d_queue queue` parameter to `v3d_job_add_syncobjs()` is redundant. The patch simply removes it and uses `job->queue` instead. ```c -v3d_job_add_syncobjs(struct v3d_job *job, struct drm_file *file_priv, - u32 in_sync, struct v3d_submit_ext *se, enum v3d_queue queue) +v3d_job_add_syncobjs(struct v3d_job *job, struct drm_file *file_priv, + u32 in_sync, struct v3d_submit_ext *se) ``` All call sites updated consistently. **No issues found.** --- Generated by Claude Code Patch Reviewer