From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/dp: split msm_dp_ctrl_config_ctrl() into link parts and stream parts Date: Thu, 04 Jun 2026 13:01:23 +1000 Message-ID: In-Reply-To: <20260602-dp_mstclean-v6-4-2c17ff40a9b2@oss.qualcomm.com> References: <20260602-dp_mstclean-v6-0-2c17ff40a9b2@oss.qualcomm.com> <20260602-dp_mstclean-v6-4-2c17ff40a9b2@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Splits `DP_CONFIGURATION_CTRL` register programming into `msm_dp_ctrl_config_ctrl_link()` and `msm_dp_ctrl_config_ctrl_streams()`. The stream function does a RMW (read-modify-write) to preserve the link bits already written. The RMW comment is appropriate: ```c /* * RMW: Called from atomic_enable(). Serialized by the DRM atomic framework. */ ``` The link function writes the register first (pure write), then the stream function reads it back and ORs in stream bits. This ordering dependency is implicit -- `msm_dp_ctrl_configure_source_params()` calls link then stream, which is correct. In the link training path (`msm_dp_ctrl_link_train`), only `msm_dp_ctrl_config_ctrl_link()` is called, which is also correct. **No issues.** --- Generated by Claude Code Patch Reviewer