From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: rust: dma: update to keyworded index projection syntax
Date: Thu, 04 Jun 2026 12:43:27 +1000 [thread overview]
Message-ID: <review-patch4-20260602-projection-syntax-rework-v2-4-6989470f5440@garyguo.net> (raw)
In-Reply-To: <20260602-projection-syntax-rework-v2-4-6989470f5440@garyguo.net>
Patch Review
Converts the DMA subsystem's documentation examples and the `rust_dma` sample driver to use the new syntax.
The doc examples are updated appropriately:
```rust
-/// let whole = kernel::dma_read!(alloc, [2]?);
-/// let field = kernel::dma_read!(alloc, [1]?.field);
+/// let whole = kernel::dma_read!(alloc, [try: 2]);
+/// let field = kernel::dma_read!(alloc, [panic: 1].field);
```
Nice that this also demonstrates the `panic` flavor in the docs, showing a case where the programmer knows the index is valid.
The sample driver conversion is also good -- the `check_dma` function signature change from `fn check_dma(&self) -> Result` to `fn check_dma(&self)` is a logical consequence of switching from `[try: i]` (which uses `?` and thus requires `Result` return) to `[panic: i]` (which panics directly and doesn't need error propagation). The call site is simplified accordingly:
```rust
- assert!(self.check_dma().is_ok());
+ self.check_dma();
```
This is a good change -- the old `assert!(is_ok())` was effectively panicking on error anyway, so the `panic` variant is semantically equivalent but cleaner.
Already has Reviewed-by from Alice, Andreas, and Alexandre. No issues.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 2:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 14:17 [PATCH v2 0/6] Rework index projection syntax Gary Guo
2026-06-02 14:17 ` [PATCH v2 1/6] rust: ptr: rename `ProjectIndex::index` to `build_index` Gary Guo
2026-06-04 2:43 ` Claude review: " Claude Code Review Bot
2026-06-02 14:17 ` [PATCH v2 2/6] rust: ptr: use `match` instead of `unwrap_or_else` for `build_index` Gary Guo
2026-06-04 2:43 ` Claude review: " Claude Code Review Bot
2026-06-02 14:17 ` [PATCH v2 3/6] rust: ptr: add panicking index projection variant Gary Guo
2026-06-04 2:43 ` Claude review: " Claude Code Review Bot
2026-06-02 14:17 ` [PATCH v2 4/6] rust: dma: update to keyworded index projection syntax Gary Guo
2026-06-04 2:43 ` Claude Code Review Bot [this message]
2026-06-02 14:17 ` [PATCH v2 5/6] gpu: nova-core: convert to keyworded " Gary Guo
2026-06-04 2:43 ` Claude review: " Claude Code Review Bot
2026-06-02 14:17 ` [PATCH v2 6/6] rust: ptr: remove implicit index " Gary Guo
2026-06-04 2:43 ` Claude review: " Claude Code Review Bot
2026-06-02 15:03 ` [PATCH v2 0/6] Rework " Danilo Krummrich
2026-06-04 2:43 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch4-20260602-projection-syntax-rework-v2-4-6989470f5440@garyguo.net \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox