From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/xe/hw_error: Use HW_ERR prefix in log Date: Thu, 04 Jun 2026 13:22:00 +1000 Message-ID: In-Reply-To: <20260602044919.702209-5-raag.jadav@intel.com> References: <20260602044919.702209-1-raag.jadav@intel.com> <20260602044919.702209-5-raag.jadav@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Verdict: Fine, minor nit.** Adds the standard kernel `HW_ERR` (`"[Hardware Error]: "`) prefix to the `l= og_hw_error`, `log_gt_err`, and `log_soc_error` functions. The file already= uses `HW_ERR` extensively elsewhere (e.g., lines 199, 207, 443, 475, 479 i= n the patched file), so this makes these functions consistent. **Minor nit:** The `Fixes:` tag references `01aab7e1c9d4 ("drm/xe/xe_hw_err= or: Add support for PVC SoC errors")`. Using a Fixes tag implies stable-ker= nel backport eligibility, which seems heavy for a log-format consistency ch= ange. This is ultimately a maintainer judgment call =E2=80=94 if there's to= oling that relies on `HW_ERR` for parsing or alerting, the Fixes tag is jus= tified. --- Generated by Claude Code Patch Reviewer