From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: rust: gem: shmem: Fix Default implementation for ObjectConfig
Date: Thu, 04 Jun 2026 12:29:54 +1000
Message-ID: <review-patch4-20260602172807.1051806-5-lyude@redhat.com>
In-Reply-To: <20260602172807.1051806-5-lyude@redhat.com>
References: <20260602172807.1051806-1-lyude@redhat.com> <20260602172807.1051806-5-lyude@redhat.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Straightforward fix. `#[derive(Default)]` requires `T: Default` for all generic parameters, but `ObjectConfig` only uses `T` in `Option<&'a Object<T>>` which defaults to `None` regardless of `T`'s `Default` impl. The manual implementation correctly removes the spurious bound:
```rust
impl<'a, T: DriverObject> Default for ObjectConfig<'a, T> {
    fn default() -> Self {
        Self {
            map_wc: false,
            parent_resv_obj: None,
        }
    }
}
```

No issues.

---
Generated by Claude Code Patch Reviewer