From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amd/display: use plane color_mgmt_changed to track colorop changes
Date: Thu, 04 Jun 2026 12:16:44 +1000
Message-ID: <review-patch4-20260602215743.914265-5-mwen@igalia.com>
In-Reply-To: <20260602215743.914265-5-mwen@igalia.com>
References: <20260602215743.914265-1-mwen@igalia.com> <20260602215743.914265-5-mwen@igalia.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Author:** Melissa Wen

Wires up the new `plane_state->color_mgmt_changed` flag in AMD's display dr=
iver, at two critical decision points:

1. **`amdgpu_dm_commit_planes()`** (line 10218): The condition for sending =
color surface updates to DC now checks `new_plane_state->color_mgmt_changed=
` in addition to `new_pcrtc_state->color_mgmt_changed`:

   ```c
   if (new_pcrtc_state->color_mgmt_changed || new_plane_state->color_mgmt_c=
hanged) {
   ```

   This ensures that when a colorop property changes (e.g., shaper/3D-LUT u=
pdate for gamescope night mode), the driver actually sends the updated gamm=
a, transfer functions, gamut remap, HDR mult, shaper, 3D LUT, and blend TF =
to DC.

2. **`should_reset_plane()`** (line 12060=E2=80=9312062): Returns `true` wh=
en `new_plane_state->color_mgmt_changed` is set, causing the plane to be re=
moved from and re-added to the DC state. This is the same behavior already =
triggered by `new_crtc_state->color_mgmt_changed`.

**Verdict:** Correct, minimal, and directly fixes the reported gamescope is=
sue. No issues.

---
Generated by Claude Code Patch Reviewer