From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: soc: qcom: ubwc: Add Shikra UBWC config Date: Thu, 04 Jun 2026 11:45:51 +1000 Message-ID: In-Reply-To: <20260603-shikra-display-v1-4-aeac1b94faa7@oss.qualcomm.com> References: <20260603-shikra-display-v1-0-aeac1b94faa7@oss.qualcomm.com> <20260603-shikra-display-v1-4-aeac1b94faa7@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review ```diff { .compatible =3D "qcom,sdm845", .data =3D &sdm845_data, }, + { .compatible =3D "qcom,shikra", .data =3D &no_ubwc_data, }, { .compatible =3D "qcom,sm4250", .data =3D &sm6115_data, }, ``` **This looks correct.** The `no_ubwc_data` is appropriate if Shikra has no = UBWC support. The alphabetical position is correct =E2=80=94 `"sdm845" < "s= hikra" < "sm4250"`. Note this table uses SoC-level compatibles (not `-mdss`= suffixed), which is correct for the UBWC config driver. No issues with this patch. --- Generated by Claude Code Patch Reviewer