public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: selftests/net: devmem.py: add check_rx_large_niov
Date: Fri, 05 Jun 2026 06:49:29 +1000	[thread overview]
Message-ID: <review-patch4-20260603-tcpdm-large-niovs-v1-4-f37a4ac6726c@meta.com> (raw)
In-Reply-To: <20260603-tcpdm-large-niovs-v1-4-f37a4ac6726c@meta.com>

Patch Review

**Substantive issue:**

1. **Python string escape vs shell escape in `data_pipe`:**

```python
data_pipe = (f"yes $(echo -e \x01\x02\x03\x04\x05\x06) | "
             f"head -c {size} | {socat}")
```

The `\x01` through `\x06` are Python escape sequences, producing literal control-character bytes (SOH, STX, etc.) embedded in the shell command string. While this technically works (echo -e will pass through raw bytes that aren't backslash sequences), it's fragile -- some shells or SSH transports may not handle embedded control characters in command strings reliably. Consider using raw strings (`r"\x01..."`) so that `echo -e` receives the actual backslash-escape sequences, or use a different approach for generating binary test data (e.g., `dd if=/dev/urandom bs={size} count=1`).

**Minor:**

2. **Probe caching for `rx_buf_size` variants** in `require_devmem()` is well-designed -- it caches per-size probe results to avoid redundant probes across the sweep.

3. **Test coverage is good** -- the sweep `[1024, 4096, 8192, 16384, 32768, 65536]` nicely brackets the 16384 niov boundary (sub-niov, exact-niov, 2x, 4x).

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-06-04 20:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-04  0:42 [PATCH net-next 0/4] net: devmem: allow rx-buf-size > PAGE_SIZE per binding Bobby Eshleman
2026-06-04  0:42 ` [PATCH net-next 1/4] net: devmem: allow rx-buf-size > PAGE_SIZE per dmabuf binding Bobby Eshleman
2026-06-04 20:49   ` Claude review: " Claude Code Review Bot
2026-06-04  0:42 ` [PATCH net-next 2/4] udmabuf: emit one sg entry per pinned folio Bobby Eshleman
2026-06-04 20:49   ` Claude review: " Claude Code Review Bot
2026-06-04  0:43 ` [PATCH net-next 3/4] selftests/net: ncdevmem: add -b option to set rx-buf-size on bind Bobby Eshleman
2026-06-04 20:49   ` Claude review: " Claude Code Review Bot
2026-06-04  0:43 ` [PATCH net-next 4/4] selftests/net: devmem.py: add check_rx_large_niov Bobby Eshleman
2026-06-04 20:49   ` Claude Code Review Bot [this message]
2026-06-04 20:49 ` Claude review: net: devmem: allow rx-buf-size > PAGE_SIZE per binding Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch4-20260603-tcpdm-large-niovs-v1-4-f37a4ac6726c@meta.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox