From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/v3d: Replace spin_lock_irqsave() with spin_lock() Date: Thu, 04 Jun 2026 11:24:40 +1000 Message-ID: In-Reply-To: <20260603-v3d-sched-misc-fixes-v3-4-d7114bba55a0@igalia.com> References: <20260603-v3d-sched-misc-fixes-v3-0-d7114bba55a0@igalia.com> <20260603-v3d-sched-misc-fixes-v3-4-d7114bba55a0@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Now that `queue_lock` is no longer used as the fence lock (patch 3), and the commit message correctly notes that only `v3d_overflow_mem_work()` and `v3d_bin_job_run()` (both workqueue context) take this lock, `irqsave` is unnecessary. The conversion to `scoped_guard(spinlock, ...)` is clean. One subtlety worth noting: in `v3d_overflow_mem_work()`, the `goto out` inside the `scoped_guard` block correctly jumps past the guard's scope, which will automatically release the lock on scope exit. This is correct behavior with `scoped_guard`. Reviewed-by: Tvrtko Ursulin. No issues. --- Generated by Claude Code Patch Reviewer