From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: mediatek: mt8167: Add DRM nodes Date: Tue, 24 Feb 2026 10:06:13 +1000 Message-ID: In-Reply-To: <36762766bc2b6629eefc5f1adb5e98555df1f34b.1771863641.git.l.scorcia@gmail.com> References: <36762766bc2b6629eefc5f1adb5e98555df1f34b.1771863641.git.l.scorcia@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This is the main DTS patch adding all display-related nodes. The display pipeline is correctly wired: > + mmsys_main: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&ovl0_in>; > + }; through to: > + port@0 { > + reg = <0>; > + dsi_in: endpoint { > + remote-endpoint = <&rdma0_out>; > + }; > + }; This pipeline (mmsys -> OVL0 -> COLOR -> CCORR -> AAL -> GAMMA -> DITHER -> RDMA0 -> DSI) matches the `mt8167_mtk_ddp_main` array already in `mtk_drm_drv.c`. The ext path (mmsys endpoint@1 -> rdma1) is also present with rdma1 set to `status = "disabled"`. The new nodes are correctly ordered by MMIO address, maintaining the ordering established in patch 1. The `mmsys` node appropriately gains a `power-domains` property. All blocks that need it have `iommus`, `power-domains`, `clocks`, and `interrupts` properties. The `dsi` and `mipi_tx` nodes are both `status = "disabled"` by default, to be enabled per board. Already has a Reviewed-by from AngeloGioacchino Del Regno. --- Generated by Claude Code Patch Reviewer