From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: block: introduce dma map backed bio type Date: Tue, 05 May 2026 11:26:00 +1000 Message-ID: In-Reply-To: <646ecd6fde8d9e146cb051efb514deb27ce3883e.1777475843.git.asml.silence@gmail.com> References: <646ecd6fde8d9e146cb051efb514deb27ce3883e.1777475843.git.asml.silence@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Introduces `BIO_DMABUF_MAP` flag and unions `bi_io_vec` with `dmabuf_map` in `struct bio`. The splitting logic in `bio_split_io_at` treats the dmabuf map as a single segment. **Typo in commit message:** "strore" should be "store". **Minor: `__bio_split_to_limits` always enters `bio_split_rw` for dmabuf bios** ```c if (bio_may_need_split(bio, lim) || bio_flagged(bio, BIO_DMABUF_MAP)) return bio_split_rw(bio, lim, nr_segs); ``` This means every dmabuf bio goes through the full split path even when it doesn't need splitting. This shouldn't be a hot path (dmabuf bios are already marked `REQ_NOMERGE`), but it's worth noting that the dmabuf path in `bio_split_io_at` could return early more efficiently. --- --- Generated by Claude Code Patch Reviewer