From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: hid: Pen battery quirk for Surface Pro 12in Date: Sat, 16 May 2026 09:57:53 +1000 Message-ID: In-Reply-To: References: X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Adds `HID_BATTERY_QUIRK_IGNORE` for the Elan touchscreen controller on this= device: ```c +#define I2C_DEVICE_ID_SURFACE_PRO_12IN 0x4376 ``` ```c + { HID_I2C_DEVICE(USB_VENDOR_ID_ELAN, I2C_DEVICE_ID_SURFACE_PRO_12IN), + HID_BATTERY_QUIRK_IGNORE }, ``` The commit message explains the pen reports battery over Bluetooth, not I2C= , so querying the I2C device for battery either shows a phantom battery or = causes hangs. Using `HID_BATTERY_QUIRK_IGNORE` (not `AVOID_QUERY` like the = Trogdor entry above it) is appropriate since the battery shouldn't be repor= ted at all from this path. Already Acked-by Jiri Kosina. **Minor nit:** The `#define` uses two spaces before `0x4376` =E2=80=94 othe= r defines in hid-ids.h typically use a tab. This is cosmetic and likely fin= e. **No functional issues.** --- --- Generated by Claude Code Patch Reviewer