From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: video: fm2fb: Use named initializer for zorro_device_id array Date: Wed, 27 May 2026 14:47:33 +1000 Message-ID: In-Reply-To: <12911d2a1dfc4e482bbc0a417df73748283d04ee.1779803053.git.u.kleine-koenig@baylibre.com> References: <12911d2a1dfc4e482bbc0a417df73748283d04ee.1779803053.git.u.kleine-koenig@baylibre.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Looks good.** This converts two `zorro_device_id` entries from positional to named initia= lizers: ```c - { ZORRO_PROD_BSC_FRAMEMASTER_II }, - { ZORRO_PROD_HELFRICH_RAINBOW_II }, - { 0 } + { .id =3D ZORRO_PROD_BSC_FRAMEMASTER_II }, + { .id =3D ZORRO_PROD_HELFRICH_RAINBOW_II }, + { } ``` The change is straightforward and correct. The `{ 0 }` to `{ }` change for = the terminator is a minor style cleanup =E2=80=94 both produce identical bi= nary output (all-zeros), but `{ }` is the idiomatic way to express "zero-in= itialized struct" without implying a specific field. This is required prepa= ration for patch 6, since the anonymous union cannot be initialized via pos= itional syntax. No concerns. --- Generated by Claude Code Patch Reviewer