public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: qcom: sdm670-google: add common device tree include
Date: Wed, 11 Feb 2026 16:47:58 +1000	[thread overview]
Message-ID: <review-patch5-20260210023300.15785-6-mailingradian@gmail.com> (raw)
In-Reply-To: <20260210023300.15785-6-mailingradian@gmail.com>

Patch Review

**CRITICAL - License Change:**

```diff
-// SPDX-License-Identifier: GPL-2.0
+// SPDX-License-Identifier: GPL-2.0-only
```

The original is GPL-2.0 (v2 or later), the new file is GPL-2.0-only (ONLY v2). This is a **license restriction** that requires:
- Explicit justification in commit message
- Legal review
- Permission from copyright holders

If unintentional, keep GPL-2.0. If intentional, explain why in the commit message.

**CRITICAL - Undocumented Functional Change:**

```diff
 		rmi4_f12: rmi4-f12@12 {
 			reg = <0x12>;
-			touchscreen-x-mm = <62>;
-			touchscreen-y-mm = <127>;
 			syna,sensor-type = <1>;
 		};
```

Then in new sargo.dts:

```diff
+&rmi4_f12 {
+	touchscreen-x-mm = <63>;
+	touchscreen-y-mm = <127>;
+};
```

The X dimension changed from **62mm to 63mm**. This is a functional change buried in a refactoring patch. Either:
- Explain in commit message why this changed
- Put in separate patch
- Verify this isn't a typo

**Style Issue - Comment Format:**

```diff
 	panel: panel@0 {
-		compatible = "samsung,s6e3fa7-ams559nk06";
+		// compatible is provided in specific device trees
```

Kernel device tree files should use C-style comments:

```c
/* compatible is provided in specific device trees */
```

**Copyright Year:**

```diff
- * Copyright (c) 2022, Richard Acayan. All rights reserved.
+ * Copyright (c) 2023, Richard Acayan. All rights reserved.
```

Submitted in 2026 but claims 2023. Should be "2022-2026" or similar.

**Positive Aspects:**
- Logical refactoring that moves ~700 lines of common code
- Correct separation of device-specific (battery capacity, panel type, dimensions) from common (regulators, peripherals)
- Framebuffer properly disabled in common and enabled in device-specific

**Rating:** NEEDS REVISION - License change needs justification, touchscreen change needs explanation, use C-style comments

---

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-02-11  6:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-10  2:32 [PATCH 0/6] Support for the Pixel 3a XL with the Tianma panel Richard Acayan
2026-02-10  2:32 ` [PATCH 1/6] dt-bindings: arm: qcom: document google, bonito-tianma board Richard Acayan
2026-02-10  9:12   ` Krzysztof Kozlowski
2026-02-11  6:47   ` Claude review: " Claude Code Review Bot
2026-02-10  2:32 ` [PATCH 2/6] dt-bindings: panel-simple-dsi: add nt37700f compatible Richard Acayan
2026-02-10  9:12   ` Krzysztof Kozlowski
2026-02-11  6:47   ` Claude review: " Claude Code Review Bot
2026-02-10  2:32 ` [PATCH 3/6] drm/panel: Add Novatek/Tianma NT37700F panel Richard Acayan
2026-02-11  6:47   ` Claude review: " Claude Code Review Bot
2026-02-10  2:32 ` [PATCH 4/6] arm64: dts: qcom: sdm670-google-sargo: add touchscreen and display labels Richard Acayan
2026-02-11  6:47   ` Claude review: " Claude Code Review Bot
2026-02-10  2:32 ` [PATCH 5/6] arm64: dts: qcom: sdm670-google: add common device tree include Richard Acayan
2026-02-11  6:47   ` Claude Code Review Bot [this message]
2026-02-12 10:30   ` Konrad Dybcio
2026-02-10  2:33 ` [PATCH 6/6] arm64: dts: qcom: add support for pixel 3a xl with the tianma panel Richard Acayan
2026-02-10  9:10   ` Konrad Dybcio
2026-02-11 19:33     ` Richard Acayan
2026-02-12 10:29       ` Konrad Dybcio
2026-02-11  6:47   ` Claude review: " Claude Code Review Bot
2026-02-11  6:47 ` Claude review: Support for the Pixel 3a XL with the Tianma panel Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch5-20260210023300.15785-6-mailingradian@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox