From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: qcom: sdm670-google: add common device tree
 include
Date: Wed, 11 Feb 2026 16:47:58 +1000
Message-ID: <review-patch5-20260210023300.15785-6-mailingradian@gmail.com>
In-Reply-To: <20260210023300.15785-6-mailingradian@gmail.com>
References: <20260210023300.15785-1-mailingradian@gmail.com> <20260210023300.15785-6-mailingradian@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Mailer: Claude Code Patch Reviewer

Patch Review

**CRITICAL - License Change:**

```diff
-// SPDX-License-Identifier: GPL-2.0
+// SPDX-License-Identifier: GPL-2.0-only
```

The original is GPL-2.0 (v2 or later), the new file is GPL-2.0-only (ONLY v2). This is a **license restriction** that requires:
- Explicit justification in commit message
- Legal review
- Permission from copyright holders

If unintentional, keep GPL-2.0. If intentional, explain why in the commit message.

**CRITICAL - Undocumented Functional Change:**

```diff
 		rmi4_f12: rmi4-f12@12 {
 			reg = <0x12>;
-			touchscreen-x-mm = <62>;
-			touchscreen-y-mm = <127>;
 			syna,sensor-type = <1>;
 		};
```

Then in new sargo.dts:

```diff
+&rmi4_f12 {
+	touchscreen-x-mm = <63>;
+	touchscreen-y-mm = <127>;
+};
```

The X dimension changed from **62mm to 63mm**. This is a functional change buried in a refactoring patch. Either:
- Explain in commit message why this changed
- Put in separate patch
- Verify this isn't a typo

**Style Issue - Comment Format:**

```diff
 	panel: panel@0 {
-		compatible = "samsung,s6e3fa7-ams559nk06";
+		// compatible is provided in specific device trees
```

Kernel device tree files should use C-style comments:

```c
/* compatible is provided in specific device trees */
```

**Copyright Year:**

```diff
- * Copyright (c) 2022, Richard Acayan. All rights reserved.
+ * Copyright (c) 2023, Richard Acayan. All rights reserved.
```

Submitted in 2026 but claims 2023. Should be "2022-2026" or similar.

**Positive Aspects:**
- Logical refactoring that moves ~700 lines of common code
- Correct separation of device-specific (battery capacity, panel type, dimensions) from common (regulators, peripherals)
- Framebuffer properly disabled in common and enabled in device-specific

**Rating:** NEEDS REVISION - License change needs justification, touchscreen change needs explanation, use C-style comments

---

---
Generated by Claude Code Patch Reviewer