From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/ci: add rk3588-rock-5b
Date: Thu, 12 Feb 2026 15:48:42 +1000
Message-ID: <review-patch5-20260210071138.2256773-6-vignesh.raman@collabora.com>
In-Reply-To: <20260210071138.2256773-6-vignesh.raman@collabora.com>
References: <20260210071138.2256773-1-vignesh.raman@collabora.com> <20260210071138.2256773-6-vignesh.raman@collabora.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Mailer: Claude Code Patch Reviewer

Patch Review

**Commit:** `866100685f8a3`

Adds CI jobs for the RK3588 Rock 5B board, running both rockchip display and panthor GPU tests.

Key additions:

1. **MAINTAINERS:** Adds `drivers/gpu/drm/ci/xfails/panthor*` to the Panthor section.

2. **arm64.config:** Enables `CONFIG_DRM_PANTHOR=m`, `CONFIG_PHY_ROCKCHIP_NANENG_COMBO_PHY=y`, and `CONFIG_PHY_ROCKCHIP_SAMSUNG_HDPTX=y`.

3. **build.sh:** Adds `rk3588-rock-5b.dtb` to the device tree list.

4. **gitlab-ci.yml:** Adds `panthor` stage.

5. **igt_runner.sh:** Adds `panthor` to the module-loading case alongside `amdgpu|vkms`.

6. **test.yml:** Adds `.rk3588` template, `rockchip:rk3588` display job, and `panthor:rk3588` GPU job.

7. **New expectation files:** `panthor-rk3588-fails.txt`, `panthor-rk3588-skips.txt`, `rockchip-rk3588-fails.txt`, `rockchip-rk3588-skips.txt`.

**Analysis of the .rk3588 template:**
```yaml
.rk3588:
  extends:
    - .lava-igt:arm64
    - .rockchip-device
  parallel: 2
  variables:
    DEVICE_TYPE: rk3588-rock-5b
    GPU_VERSION: rk3588
    BOOT_METHOD: u-boot
    KERNEL_IMAGE_NAME: Image
    KERNEL_IMAGE_TYPE: "image"
    RUNNER_TAG: mesa-ci-x86-64-lava-rk3588-rock-5b
```

This uses `u-boot` boot method (unlike the depthcharge-based rk3399), `Image` (uncompressed, not `.gz`), and `KERNEL_IMAGE_TYPE: "image"`. This is consistent with how u-boot based boards are handled.

The `.rockchip-device` parent template includes `LAVA_FIRMWARE: arm`, which provides ARM firmware for the board.

**Panthor skip list observations:** The panthor skip list skips all KMS tests (`kms_.*`) with the comment "Panfrost is not a KMS driver, so skip the KMS tests" — but this is for panthor, not panfrost. The comment is misleading, though the intent is correct: panthor is also a GPU-only driver without KMS functionality. The skip regex is correct regardless of the comment.

**Verdict:** Well-structured addition. The misleading comment about "Panfrost" in the panthor skip file is a minor cosmetic issue.

---

## SUMMARY

| Patch | Subject | Issues |
|-------|---------|--------|
| 1/5 | reduce sm8350-hdk parallel jobs | None |
| 2/5 | i915: cml: update runner tag | None |
| 3/5 | uprev mesa | None (large but well-reviewed) |
| 4/5 | move qualcomm baremetal jobs to lava | Minor: dropped `clk_ignore_unused` and `maxcpus=2` not discussed in commit message |
| 5/5 | add rk3588-rock-5b | Minor: misleading "Panfrost" comment in panthor skip file |

**Overall assessment:** This is a clean CI infrastructure series with proper review tags and tested pipelines. The changes are well-organized across the 5 patches. No kernel runtime regressions are possible as these are purely CI configuration changes. The two minor observations (dropped kernel boot args in patch 4, wrong driver name in a comment in patch 5) are cosmetic and do not affect functionality.

---
Generated by Claude Code Patch Reviewer