From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/exynos: exynos_dp: Apply of-display-mode-bridge to parse the display-timings node Date: Wed, 11 Feb 2026 16:37:16 +1000 Message-ID: In-Reply-To: <20260210071225.2566099-6-damon.ding@rock-chips.com> References: <20260210071225.2566099-1-damon.ding@rock-chips.com> <20260210071225.2566099-6-damon.ding@rock-chips.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Mailer: Claude Code Patch Reviewer Patch Review **Summary:** Uses the new generic of-display-mode-bridge instead of custom parsing logic. **Before:** ```c -static int exynos_dp_get_modes(struct analogix_dp_plat_data *plat_data, - struct drm_connector *connector) -{ - struct exynos_dp_device *dp = to_dp(plat_data); - struct drm_display_mode *mode; - - mode = drm_mode_create(connector->dev); - if (!mode) { - DRM_DEV_ERROR(dp->dev, - "failed to create a new display mode.\n"); - return 0; - } - - drm_display_mode_from_videomode(&dp->vm, mode); ``` **After:** ```c + ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, &panel, &bridge); + if (ret == -ENODEV) { + dp->plat_data.next_bridge = devm_drm_of_display_mode_bridge(dp->dev, + dp->dev->of_node, + DRM_MODE_CONNECTOR_eDP); ``` **Review:** - Removes 27 lines of custom code in favor of generic helper - The `has_of_bridge` flag is temporary (mentioned in commit message) - acceptable for staged refactoring - Error handling is preserved **Concern:** The temporary flag creates technical debt, but patch 9 should remove it. **Verdict:** Good refactoring, verify flag removal in later patches. --- --- Generated by Claude Code Patch Reviewer