From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/v3d: Use devm_reset_control_get_optional_exclusive() Date: Sat, 14 Feb 2026 07:21:53 +1000 Message-ID: In-Reply-To: <20260213-v3d-power-management-v5-5-7a8b381eb379@igalia.com> References: <20260213-v3d-power-management-v5-0-7a8b381eb379@igalia.com> <20260213-v3d-power-management-v5-5-7a8b381eb379@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review > - v3d->reset =3D devm_reset_control_get_exclusive(dev, NULL); > + v3d->reset =3D devm_reset_control_get_optional_exclusive(dev, NULL); > if (IS_ERR(v3d->reset)) { > - ret =3D PTR_ERR(v3d->reset); > + ret =3D dev_err_probe(dev, PTR_ERR(v3d->reset), > + "Failed to get reset control\n"); > + goto clk_disable; > + } > =20 > - if (ret =3D=3D -EPROBE_DEFER) > - goto clk_disable; > - > - v3d->reset =3D NULL; > + if (!v3d->reset) { > ret =3D map_regs(v3d, &v3d->bridge_regs, "bridge"); This is a clean simplification. `devm_reset_control_get_optional_exclusive()`= returns NULL when no reset is specified in DT (instead of an error), making = the flow clearer. The `dev_err_probe()` usage also properly handles `-EPROBE_= DEFER` without a special case. Note that this patch is immediately superseded by patch 6, which moves this c= ode block. This is fine for bisectability -- each patch is correct on its own= -- but worth noting that this patch exists mainly for clarity of the refacto= ring. No issues found. --- Generated by Claude Code Patch Reviewer