From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel: r61307/r69328: convert to devm_mipi_dsi_attach Date: Sun, 15 Feb 2026 20:24:19 +1000 Message-ID: In-Reply-To: <20260215085140.20499-6-clamor95@gmail.com> References: <20260215085140.20499-1-clamor95@gmail.com> <20260215085140.20499-6-clamor95@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Replaces `mipi_dsi_attach()` / manual `mipi_dsi_detach()` with `devm_mipi_dsi= _attach()`. The manual detach in `remove()` is deleted. Ordering is correct: the `remove()` callback (which calls `drm_panel_remove()= `) executes before devm cleanup (which calls `mipi_dsi_detach()`), maintainin= g the same order as the original code. This is the standard pattern used by m= any panel drivers (e.g., panel-samsung-ams581vf01, panel-magnachip-d53e6ea896= 6, panel-lg-ld070wx3). No regressions. --- FINAL REGRESSIONS FOUND: 0 False positives eliminated: - `drm_connector_helper_get_modes_fixed` returning 0 vs -ENOMEM: framework cl= amps negative returns to 0 in `drm_panel_get_modes()` - Double-OR of `DRM_MODE_TYPE_PREFERRED`: idempotent bit operation - devm cleanup ordering: `remove()` runs before devm teardown, preserving cor= rect order - DT property rename breaking users: no in-tree DTS files use either name --- `review-metadata.json` content (could not write due to permissions): ```json { "author": "Svyatoslav Ryhel ", "sha": "c0c75a7fd8740..5d718d96a1186", "subject": "drm/panel: r61307/r69328: modernization series", "AI-authorship-score": "low", "AI-authorship-explanation": "Mechanical driver cleanup by a known panel dr= iver contributor, following standard kernel modernization patterns with terse= commit messages.", "issues-found": 0, "issue-severity-score": "low", "issue-severity-explanation": "none" } ``` FINAL TOKENS USED: ~45000 (estimated) --- Generated by Claude Code Patch Reviewer