From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: gsp: derive `Debug` on more sequencer types Date: Tue, 17 Feb 2026 15:48:07 +1000 Message-ID: In-Reply-To: <20260217-nova-misc-v3-5-b4e2d45eafbc@nvidia.com> References: <20260217-nova-misc-v3-0-b4e2d45eafbc@nvidia.com> <20260217-nova-misc-v3-5-b4e2d45eafbc@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds `#[derive(Debug)]` to the five payload wrapper types and to the `GspSeqCmd` enum. The wrapper types are `#[repr(transparent)]` over bindgen-generated structs. Since bindgen-generated structs for these GSP payloads typically derive `Debug`, the derived `Debug` on the transparent wrapper will work. Even if the inner binding type doesn't implement `Debug`, this wouldn't compile, so there's no risk of a subtle runtime issue. > +#[derive(Copy, Clone, Debug)] > pub(crate) struct RegWritePayload(bindings::GSP_SEQ_BUF_PAYLOAD_REG_WRITE); > +#[derive(Debug)] > pub(crate) enum GspSeqCmd { No issues found. --- Generated by Claude Code Patch Reviewer