From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: qcom: sdm670-google: add common device tree include
Date: Tue, 17 Feb 2026 15:51:44 +1000 [thread overview]
Message-ID: <review-patch5-20260217000854.131242-6-mailingradian@gmail.com> (raw)
In-Reply-To: <20260217000854.131242-6-mailingradian@gmail.com>
Patch Review
This is the main refactoring patch. The approach of extracting common elements into `sdm670-google-common.dtsi` and making per-device DTS files thin overlays is clean.
> - charge-full-design-microamp-hours = <3000000>;
The `charge-full-design-microamp-hours` property is removed from the common include and added back in the sargo-specific DTS with the same value. This makes sense since the 3a XL has a different battery capacity (3700 mAh vs 3000 mAh).
> + framebuffer: framebuffer@9c000000 {
> + compatible = "simple-framebuffer";
> + /* dimensions and size are in specific device trees */
> + format = "a8r8g8b8";
> + status = "disabled";
> };
The framebuffer is disabled in the common include and re-enabled with device-specific dimensions in each board DTS. However, `simple-framebuffer` nodes without `reg`, `width`, `height`, and `stride` properties are incomplete. Since the node is `status = "disabled"`, this is fine at runtime, but it may generate DT validation warnings. The `reg` property is also omitted from the common include but provided in the per-device overrides.
> +&rmi4_f12 {
> + touchscreen-x-mm = <63>;
> + touchscreen-y-mm = <127>;
> +};
The original sargo DTS had `touchscreen-x-mm = <62>`, but the new sargo DTS sets it to `<63>`. Is this an intentional correction, or a typo introduced during the refactoring? The commit message doesn't mention this change. If intentional, it would be worth noting in the commit message.
> - panel: panel@0 {
> - compatible = "samsung,s6e3fa7-ams559nk06";
> + panel: panel@0 {
> + /* compatible is provided in specific device trees */
> reg = <0>;
The panel node is left without a `compatible` and with `status = "disabled"` in the common include. This is correct -- the per-device DTS provides both the compatible and `status = "okay"`.
> -// SPDX-License-Identifier: GPL-2.0
> +// SPDX-License-Identifier: GPL-2.0-only
The SPDX license identifier changed from `GPL-2.0` to `GPL-2.0-only` in the new sargo DTS. While `GPL-2.0-only` is more precise, this is a license change that should probably be noted in the commit message or handled as a separate patch, as it changes the licensing terms.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-02-17 5:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 0:08 [PATCH v2 0/6] Support for the Pixel 3a XL with the Tianma panel Richard Acayan
2026-02-17 0:08 ` [PATCH v2 1/6] dt-bindings: arm: qcom: document google, bonito-tianma board Richard Acayan
2026-02-17 5:51 ` Claude review: " Claude Code Review Bot
2026-02-17 0:08 ` [PATCH v2 2/6] dt-bindings: panel-simple-dsi: add nt37700f compatible Richard Acayan
2026-02-17 5:51 ` Claude review: " Claude Code Review Bot
2026-02-17 0:08 ` [PATCH v2 3/6] drm/panel: Add Novatek/Tianma NT37700F panel Richard Acayan
2026-02-17 5:51 ` Claude review: " Claude Code Review Bot
2026-02-17 0:08 ` [PATCH v2 4/6] arm64: dts: qcom: sdm670-google-sargo: add touchscreen and display labels Richard Acayan
2026-02-17 5:51 ` Claude review: " Claude Code Review Bot
2026-02-17 0:08 ` [PATCH v2 5/6] arm64: dts: qcom: sdm670-google: add common device tree include Richard Acayan
2026-02-17 5:51 ` Claude Code Review Bot [this message]
2026-02-17 0:08 ` [PATCH v2 6/6] arm64: dts: qcom: add support for pixel 3a xl with the tianma panel Richard Acayan
2026-02-17 5:51 ` Claude review: " Claude Code Review Bot
2026-02-17 5:51 ` Claude review: Support for the Pixel 3a XL with the Tianma panel Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-10 0:26 [PATCH v3 0/5] " Richard Acayan
2026-03-10 0:26 ` [PATCH v3 4/5] arm64: dts: qcom: sdm670-google: add common device tree include Richard Acayan
2026-03-10 1:42 ` Claude review: " Claude Code Review Bot
2026-02-10 2:32 [PATCH 0/6] Support for the Pixel 3a XL with the Tianma panel Richard Acayan
2026-02-10 2:32 ` [PATCH 5/6] arm64: dts: qcom: sdm670-google: add common device tree include Richard Acayan
2026-02-11 6:47 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch5-20260217000854.131242-6-mailingradian@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox