From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: pci: mark return value of pci_set_vga_state as __must_check
Date: Wed, 18 Feb 2026 06:47:58 +1000 [thread overview]
Message-ID: <review-patch5-20260217170419.236739-6-Simon.Richter@hogyros.de> (raw)
In-Reply-To: <20260217170419.236739-6-Simon.Richter@hogyros.de>
Patch Review
> -int pci_set_vga_state(struct pci_dev *pdev, bool decode,
> +int __must_check pci_set_vga_state(struct pci_dev *pdev, bool decode,
The commit message says "The only caller so far is __vga_tryget in vgaarb, which did not check." But patch 2 already added error checking to `__vga_tryget`, so at this point in the series the only caller *does* check. The commit message is slightly misleading -- it describes the pre-series state but is applied after patch 2 has already fixed it. Consider rewording to say the caller now checks (as of patch 2), so this annotation is safe to add.
No functional issues with this patch.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-02-17 20:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 17:04 [PATCH 0/5] bridges without VGA support Simon Richter
2026-02-17 17:04 ` [PATCH 1/5] vgaarb: pass vga_get errors to userspace Simon Richter
2026-02-17 20:47 ` Claude review: " Claude Code Review Bot
2026-02-17 17:04 ` [PATCH 2/5] vgaarb: pass errors from pci_set_vga_state up Simon Richter
2026-02-17 20:47 ` Claude review: " Claude Code Review Bot
2026-02-17 17:04 ` [PATCH 3/5] vgaarb: mark vga_get family as __must_check Simon Richter
2026-02-17 20:47 ` Claude review: " Claude Code Review Bot
2026-02-17 17:04 ` [PATCH 4/5] pci: check if VGA decoding was really activated Simon Richter
2026-02-17 20:47 ` Claude review: " Claude Code Review Bot
2026-02-17 17:04 ` [PATCH 5/5] pci: mark return value of pci_set_vga_state as __must_check Simon Richter
2026-02-17 20:47 ` Claude Code Review Bot [this message]
2026-02-17 20:47 ` Claude review: bridges without VGA support Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch5-20260217170419.236739-6-Simon.Richter@hogyros.de \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox