From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: pci: mark return value of pci_set_vga_state as __must_check Date: Wed, 18 Feb 2026 06:47:58 +1000 Message-ID: In-Reply-To: <20260217170419.236739-6-Simon.Richter@hogyros.de> References: <20260217170419.236739-1-Simon.Richter@hogyros.de> <20260217170419.236739-6-Simon.Richter@hogyros.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review > -int pci_set_vga_state(struct pci_dev *pdev, bool decode, > +int __must_check pci_set_vga_state(struct pci_dev *pdev, bool decode, The commit message says "The only caller so far is __vga_tryget in vgaarb, which did not check." But patch 2 already added error checking to `__vga_tryget`, so at this point in the series the only caller *does* check. The commit message is slightly misleading -- it describes the pre-series state but is applied after patch 2 has already fixed it. Consider rewording to say the caller now checks (as of patch 2), so this annotation is safe to add. No functional issues with this patch. --- Generated by Claude Code Patch Reviewer