From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: accel/qda: Create compute CB devices on QDA compute bus Date: Tue, 24 Feb 2026 18:20:11 +1000 Message-ID: In-Reply-To: <20260224-qda-firstpost-v1-5-fe46a9c1a046@oss.qualcomm.com> References: <20260224-qda-firstpost-v1-0-fe46a9c1a046@oss.qualcomm.com> <20260224-qda-firstpost-v1-5-fe46a9c1a046@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Creates CB devices from DT child nodes. - `kzalloc_obj(*cb_dev, GFP_KERNEL)` =E2=80=94 this macro is not standard k= ernel API. Is this a custom macro? If so, it's not introduced in this patch= . If it's from a newer kernel, it should be noted. - `qda_populate_child_devices()` silently continues on CB creation failure: ```c + if (qda_create_cb_device(qdev, child) =3D=3D 0) { + success++; + } else { + qda_err(qdev, "Failed to create CB device for: %s\n", child->name); + } ``` This means partial failure is silently accepted. Whether this is acceptable= depends on whether the driver can function with a subset of CBs. - Dmitry asked about `nsessions` support being lost. The existing fastrpc d= river handles multiple sessions per CB; this needs to be addressed. --- Generated by Claude Code Patch Reviewer