From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: fb: Add usable_vram field to FbLayout Date: Fri, 27 Feb 2026 14:25:28 +1000 Message-ID: In-Reply-To: <20260224225323.3312204-6-joelagnelf@nvidia.com> References: <20260224225323.3312204-1-joelagnelf@nvidia.com> <20260224225323.3312204-6-joelagnelf@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review The two-phase initialization approach (`new()` + `set_usable_vram()`) is reasonable given the GSP boot sequence. `#[allow(dead_code)]` on `usable_vram` is removed in patch 11 -- fine for incremental development. `saturating_add` in `set_usable_vram`: ```rust self.usable_vram = Some(base..base.saturating_add(size)); ``` If `base + size` overflows, saturating would silently create a smaller-than-expected range. Consider returning an error on overflow instead. --- Generated by Claude Code Patch Reviewer