From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dma-buf: heaps: Export mem_accounting parameter
Date: Fri, 27 Feb 2026 13:12:03 +1000 [thread overview]
Message-ID: <review-patch5-20260225-dma-buf-heaps-as-modules-v1-5-2109225a090d@kernel.org> (raw)
In-Reply-To: <20260225-dma-buf-heaps-as-modules-v1-5-2109225a090d@kernel.org>
Patch Review
```c
+EXPORT_SYMBOL_NS_GPL(mem_accounting, "DMA_BUF_HEAP");
```
**Observation:** The `DMA_BUF_HEAP` namespace is correct and matches the namespace used by `dma_heap_add()`, `dma_heap_get_drvdata()`, etc. However, `mem_accounting` is currently only used by `system_heap.c` (not `cma_heap.c`). The CMA heap imports this namespace in patch 6 anyway (for `dma_heap_add`), so this is harmless, but worth noting that `mem_accounting` isn't actually consumed by the CMA heap.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-02-27 3:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 16:41 [PATCH 0/7] dma-buf: heaps: Turn heaps into modules Maxime Ripard
2026-02-25 16:41 ` [PATCH 1/7] dma: contiguous: Turn heap registration logic around Maxime Ripard
2026-02-25 19:32 ` T.J. Mercier
2026-02-27 3:12 ` Claude review: " Claude Code Review Bot
2026-02-25 16:41 ` [PATCH 2/7] mm: cma: Export cma_alloc and cma_release Maxime Ripard
2026-02-25 19:34 ` T.J. Mercier
2026-02-26 10:25 ` David Hildenbrand (Arm)
2026-02-26 10:38 ` Maxime Ripard
2026-02-26 10:49 ` David Hildenbrand (Arm)
2026-02-26 16:58 ` T.J. Mercier
2026-02-27 3:12 ` Claude review: " Claude Code Review Bot
2026-02-25 16:41 ` [PATCH 3/7] mm: cma: Export cma_get_name Maxime Ripard
2026-02-25 19:34 ` T.J. Mercier
2026-02-27 3:12 ` Claude review: " Claude Code Review Bot
2026-02-25 16:41 ` [PATCH 4/7] mm: cma: Export dma_contiguous_default_area Maxime Ripard
2026-02-25 19:52 ` T.J. Mercier
2026-02-27 3:12 ` Claude review: " Claude Code Review Bot
2026-02-25 16:41 ` [PATCH 5/7] dma-buf: heaps: Export mem_accounting parameter Maxime Ripard
2026-02-25 19:53 ` T.J. Mercier
2026-02-27 3:12 ` Claude Code Review Bot [this message]
2026-02-25 16:41 ` [PATCH 6/7] dma-buf: heaps: cma: Turn the heap into a module Maxime Ripard
2026-02-25 19:54 ` T.J. Mercier
2026-02-27 3:12 ` Claude review: " Claude Code Review Bot
2026-02-25 16:41 ` [PATCH 7/7] dma-buf: heaps: system: " Maxime Ripard
2026-02-25 19:55 ` T.J. Mercier
2026-02-27 3:12 ` Claude review: " Claude Code Review Bot
2026-02-25 18:51 ` [PATCH 0/7] dma-buf: heaps: Turn heaps into modules John Stultz
2026-02-26 10:18 ` Maxime Ripard
2026-02-26 18:03 ` John Stultz
2026-02-27 3:12 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-03 10:13 [PATCH v3 0/8] " Maxime Ripard
2026-03-03 10:13 ` [PATCH v3 6/8] dma-buf: heaps: Export mem_accounting parameter Maxime Ripard
2026-03-03 21:41 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch5-20260225-dma-buf-heaps-as-modules-v1-5-2109225a090d@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox