From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: gsp: clarify invariant on command queue Date: Fri, 27 Feb 2026 12:21:59 +1000 Message-ID: In-Reply-To: <20260226-cmdq-continuation-v3-5-572ab9916766@nvidia.com> References: <20260226-cmdq-continuation-v3-0-572ab9916766@nvidia.com> <20260226-cmdq-continuation-v3-5-572ab9916766@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds a comment explaining why only `dst.contents.0` is used for the command header extraction: ```rust // The GSP message header and the command header // together are guaranteed to fit entirely into a single page, so it's ok to only look // at `dst.contents.0` here. ``` This is a useful clarification. The guarantee holds because `GspMsgElement` + any `Command` struct header is well under 4KB (one GSP page). The comment helps readers understand why the wrap-around second slice isn't needed for the header portion. --- Generated by Claude Code Patch Reviewer